[
https://issues.apache.org/jira/browse/DRILL-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334270#comment-15334270
]
ASF GitHub Bot commented on DRILL-4653:
---------------------------------------
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67390934
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -116,6 +117,7 @@ public void testMixedNumberTypes() throws Exception {
.jsonBaselineFile("jsoninput/mixed_number_types.json")
.build().run();
} catch (Exception ex) {
+ ex.printStackTrace();
--- End diff --
Not a good idea to print stack trace in unit tests. The output of our unit
tests is already too verbose.
Use junit.fail with the message from the exception instead?
> Malformed JSON should not stop the entire query from progressing
> ----------------------------------------------------------------
>
> Key: DRILL-4653
> URL: https://issues.apache.org/jira/browse/DRILL-4653
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JSON
> Affects Versions: 1.6.0
> Reporter: subbu srinivasan
>
> Currently Drill query terminates upon first encounter of a invalid JSON line.
> Drill has to continue progressing after ignoring the bad records. Something
> similar to a setting of (ignore.malformed.json) would help.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
