[
https://issues.apache.org/jira/browse/DRILL-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334587#comment-15334587
]
ASF GitHub Bot commented on DRILL-4725:
---------------------------------------
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/524#discussion_r67415245
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java
---
@@ -73,9 +73,12 @@ public ExprNode visitFunctionCall(FunctionCall call,
Void value) throws RuntimeE
case "like": {
ExprNode arg0 = call.args.get(0).accept(this, value);
ExprNode arg1 = call.args.get(1).accept(this, value);
+ ExprNode arg2 = call.args.size() > 2 ?
call.args.get(2).accept(this, value) : null;
--- End diff --
do you want to update these variables to have meaningful names about what
each of the arguments will be used for like you did above? Would make it a
little clearer why the ternary is only needed in the last case because the
escape is the only optional parameter.
> Improvements to InfoSchema RecordGenerator needed for DRILL-4714
> ----------------------------------------------------------------
>
> Key: DRILL-4725
> URL: https://issues.apache.org/jira/browse/DRILL-4725
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
>
> 1. Add support for pushing the filter on following fields into
> InfoSchemaRecordGenerator:
> - CATALOG_NAME
> - COLUMN_NAME
> 2. Pushdown LIKE with ESCAPE. Add test.
> 3. Add a method visitCatalog() to InfoSchemaRecordGenerator to decide whether
> to explore the catalog or not
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
