[
https://issues.apache.org/jira/browse/DRILL-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342753#comment-15342753
]
ASF GitHub Bot commented on DRILL-4733:
---------------------------------------
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/531#discussion_r67955187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
@@ -126,8 +127,12 @@ CloseableRecordBatch getReaderBatch(FragmentContext
context, EasySubScan scan) t
final ImplicitColumnExplorer columnExplorer = new
ImplicitColumnExplorer(context, scan.getColumns());
if (!columnExplorer.isSelectAllColumns()) {
+ // We must make sure to pass a table column (not to be confused with
implicit column) to the underlying record reader.
+ List<SchemaPath> tableColumns =
--- End diff --
Ok, I see. Although this patch resolves this issue, I am thinking that
without doing a performance test it is not feasible to see the performance
impact of the overall implicit columns support. It is a nice feature to have
but I think we can give it a little more time to go through functional and perf
tests.
> max(dir0) reading more columns than necessary
> ---------------------------------------------
>
> Key: DRILL-4733
> URL: https://issues.apache.org/jira/browse/DRILL-4733
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization, Storage - Parquet
> Affects Versions: 1.7.0
> Reporter: Rahul Challapalli
> Assignee: Arina Ielchiieva
> Priority: Critical
> Fix For: 1.7.0
>
> Attachments: bug.tgz
>
>
> The below query started to fail from this commit :
> 3209886a8548eea4a2f74c059542672f8665b8d2
> {code}
> select max(dir0) from dfs.`/drill/testdata/bug/2016`;
> Error: UNSUPPORTED_OPERATION ERROR: Streaming aggregate does not support
> schema changes
> Fragment 0:0
> [Error Id: b0060205-e9a6-428a-9803-7b4312b2c6f4 on qa-node190.qa.lab:31010]
> (state=,code=0)
> {code}
> The sub-folders contains files which do have schema change for one column
> "contributions" (int32 vs double). However prior to this commit we did not
> fail in the scenario. Log files and test data are attached
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
