[ 
https://issues.apache.org/jira/browse/DRILL-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454406#comment-15454406
 ] 

Holman Lan commented on DRILL-4420:
-----------------------------------

Thank you for your answers, Laurent. A few more questions.

In FieldMetadata, which field can we use to get the value for SQL_DESC_LENGTH 
(which may be different then SQL_DESC_OCTET_LENGTH, especially for Unicode 
characters)?

There was a typo in one of the sentences in my previous comment. By "ODBC (and 
JDBC) does not allow pattern for catalog function calls ..." I meant to say 
"ODBC (and JDBC) does not allow pattern for catalog name restriction for the 
catalog functions ...". Sorry about that. Would drill be able to treat catalog 
name restriction as literal string? If this is a use case you are trying to 
support or if you feel that this would make it inconsistent with the other 
restrictions then not a problem, we will make sure to escape any reserved 
characters before passing it in. 

For getTables and getColumns in JDBC and SQLTables and SQLColumns, passing in 
null for catalog name or schema pattern means the restrictions "should not be 
used to narrow the search", whereas passing in an empty string for the two 
restrictions has different meaning (tables that do not belong to a catalog or 
schema). Since the getTables and getColumns Drill client API calls take a const 
string reference for catalogPattern and schemaPattern, if we get null for the 
two restrictions from the ODBC layer are we expected to just set % for the 
restrictions? If that is the case then I guess that would be the justification 
for keeping catalogPattern as pattern.


> C client and ODBC driver should move to using the new metadata methods 
> provided by DRILL-4385
> ---------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4420
>                 URL: https://issues.apache.org/jira/browse/DRILL-4420
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to