[
https://issues.apache.org/jira/browse/DRILL-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553339#comment-15553339
]
ASF GitHub Bot commented on DRILL-4841:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/565#discussion_r82264416
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -89,79 +88,175 @@
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Strings;
import com.google.common.util.concurrent.AbstractCheckedFuture;
+import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.SettableFuture;
/**
* Thin wrapper around a UserClient that handles connect/close and
transforms
* String into ByteBuf.
+ *
+ * To create non-default objects, use {@link DrillClient.Builder the
builder class}.
+ * E.g.
+ * <code>
+ * DrillClient client = DrillClient.newBuilder()
+ * .setConfig(...)
+ * .setIsDirectConnection(true)
--- End diff --
setDirectConnection
The "setIs" form is rather awkward. The typical convention is:
setSomething( boolean flag )
boolean isSomething( )
> Use user server event loop group for web clients
> ------------------------------------------------
>
> Key: DRILL-4841
> URL: https://issues.apache.org/jira/browse/DRILL-4841
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP
> Reporter: Sudheesh Katkam
> Assignee: Sorabh Hamirwasia
> Priority: Minor
>
> Currently we spawn an event loop group for handling requests from clients.
> This group should also be used to handles responses (from server) for web
> clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
