[
https://issues.apache.org/jira/browse/DRILL-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557170#comment-15557170
]
ASF GitHub Bot commented on DRILL-4699:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/536#discussion_r82495404
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -237,71 +281,81 @@
* DEFAULT: 64 MB
* MAXIMUM: 2048 MB
*/
- String NON_BLOCKING_OPERATORS_MEMORY_KEY =
"planner.memory.non_blocking_operators_memory";
- OptionValidator NON_BLOCKING_OPERATORS_MEMORY = new
PowerOfTwoLongValidator(
- NON_BLOCKING_OPERATORS_MEMORY_KEY, 1 << 11, 1 << 6);
+ public static final String NON_BLOCKING_OPERATORS_MEMORY_KEY =
"planner.memory.non_blocking_operators_memory";
+ public static final OptionValidator NON_BLOCKING_OPERATORS_MEMORY = new
PowerOfTwoLongValidator(
+ NON_BLOCKING_OPERATORS_MEMORY_KEY, 1 << 11, 1 << 6);
- String HASH_JOIN_TABLE_FACTOR_KEY =
"planner.memory.hash_join_table_factor";
- OptionValidator HASH_JOIN_TABLE_FACTOR = new
DoubleValidator(HASH_JOIN_TABLE_FACTOR_KEY, 1.1d);
+ public static final String HASH_JOIN_TABLE_FACTOR_KEY =
"planner.memory.hash_join_table_factor";
+ public static final OptionValidator HASH_JOIN_TABLE_FACTOR = new
DoubleValidator(HASH_JOIN_TABLE_FACTOR_KEY, 1.1d);
- String HASH_AGG_TABLE_FACTOR_KEY =
"planner.memory.hash_agg_table_factor";
- OptionValidator HASH_AGG_TABLE_FACTOR = new
DoubleValidator(HASH_AGG_TABLE_FACTOR_KEY, 1.1d);
+ public static final String HASH_AGG_TABLE_FACTOR_KEY =
"planner.memory.hash_agg_table_factor";
+ public static final OptionValidator HASH_AGG_TABLE_FACTOR = new
DoubleValidator(HASH_AGG_TABLE_FACTOR_KEY, 1.1d);
- String AVERAGE_FIELD_WIDTH_KEY = "planner.memory.average_field_width";
- OptionValidator AVERAGE_FIELD_WIDTH = new
PositiveLongValidator(AVERAGE_FIELD_WIDTH_KEY, Long.MAX_VALUE, 8);
+ public static final String AVERAGE_FIELD_WIDTH_KEY =
"planner.memory.average_field_width";
+ public static final OptionValidator AVERAGE_FIELD_WIDTH = new
PositiveLongValidator(AVERAGE_FIELD_WIDTH_KEY,
+ Long.MAX_VALUE, 8);
- BooleanValidator ENABLE_QUEUE = new
BooleanValidator("exec.queue.enable", false);
- LongValidator LARGE_QUEUE_SIZE = new
PositiveLongValidator("exec.queue.large", 1000, 10);
- LongValidator SMALL_QUEUE_SIZE = new
PositiveLongValidator("exec.queue.small", 100000, 100);
- LongValidator QUEUE_THRESHOLD_SIZE = new
PositiveLongValidator("exec.queue.threshold",
- Long.MAX_VALUE, 30000000);
- LongValidator QUEUE_TIMEOUT = new
PositiveLongValidator("exec.queue.timeout_millis",
- Long.MAX_VALUE, 60 * 1000 * 5);
+ public static final BooleanValidator ENABLE_QUEUE = new
BooleanValidator("exec.queue.enable", false);
+ public static final LongValidator LARGE_QUEUE_SIZE = new
PositiveLongValidator("exec.queue.large", 1000, 10,
+ "Sets the number of large queries that can run concurrently in the
cluster. Range: 0 - 1000.");
+ public static final LongValidator SMALL_QUEUE_SIZE = new
PositiveLongValidator("exec.queue.small", 100000, 100,
+ "Sets the number of small queries that can run concurrently in the
cluster. Range: 0 - 100000.");
+ public static final LongValidator QUEUE_THRESHOLD_SIZE = new
PositiveLongValidator("exec.queue.threshold",
+ Long.MAX_VALUE, 30000000, "Sets the cost threshold, which depends on
the complexity of the queries in" +
+ " queue, for determining whether query is large or small. Complex
queries have higher thresholds." +
+ " Range: 0 - 9223372036854775807.");
+ public static final LongValidator QUEUE_TIMEOUT = new
PositiveLongValidator("exec.queue.timeout_millis",
+ Long.MAX_VALUE, 60 * 1000 * 5, "Indicates how long a query can wait
in queue before the query fails." +
--- End diff --
Units? Secs? ms?
> Add Description Column in sys.options
> -------------------------------------
>
> Key: DRILL-4699
> URL: https://issues.apache.org/jira/browse/DRILL-4699
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server, Documentation
> Affects Versions: 1.6.0
> Reporter: John Omernik
> Assignee: Paul Rogers
>
> select * from sys.options provides a user with a strong understanding of what
> options are available to Drill. These options are not well documented. Some
> options are "experimental" other options have a function only in specific
> cases (writers vs readers for example). If we had a large text field for
> description, we could enforce documentation of the settings are option
> creation time, and the description of the setting could change as the
> versions change (i.e. when an option graduates to being supported from being
> experimental, it would be changed in the version the user is using. I.e. when
> they run select * from sys.options, they know the exact state of the option
> every time they query. It could also facilitate better self documentation via
> QA on pull requests "Did you update the sys.options.desc?" This makes it
> easier for users, and admins in the use of Drill in an enterprise.
> The first step is adding the field, and then going back and filling in the
> desc for each option. (Another JIRA after the option is available)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
