[
https://issues.apache.org/jira/browse/DRILL-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575958#comment-15575958
]
ASF GitHub Bot commented on DRILL-4934:
---------------------------------------
GitHub user joeswingle opened a pull request:
https://github.com/apache/drill/pull/617
Drill 4934
Pull Request for DRILL-4934
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hobsons/drill DRILL-4934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 8d786d430b82970e8f07fe486578b48a9e73cb69
Author: joeswingle <[email protected]>
Date: 2016-10-14T17:14:45Z
Merge remote-tracking branch 'apache/master' into DRILL-4934
commit 2b07c1b12bc5db4d62344ddf7ce8171afe2bdd2d
Author: joeswingle <[email protected]>
Date: 2016-10-06T17:47:59Z
useIP address is evaluated
the property to register the drill bit with the ipaddress was not wired
in code. Added it so that drill bits register by ipaddress.
----
> ServiceEngine does not use property useIP for DrillbitStartup
> -------------------------------------------------------------
>
> Key: DRILL-4934
> URL: https://issues.apache.org/jira/browse/DRILL-4934
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - RPC
> Affects Versions: 1.8.0
> Environment: All Envrironments.
> Reporter: Joe Swingle
> Priority: Minor
> Labels: easyfix
> Fix For: 1.9.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Our environment is configured such that two networks cannot resolve machines
> by hostname, but can connect by IP address. This creates a problem when an
> ODBC/JDBC Connection requests a Drillbit from the Zookeeper Quorum. The
> Quorum returns the hostname of the running drillbit. The Quorum should be
> capable of returning the IP Address. Changing the existing property
> _'drill.exec.rpc.use.ip_' in *drill-override.conf* did not have desired
> effect.
> Reviewing code in org.apache.drill.exec.service.ServiceEngine.java, shows the
> boolean useIP is set to false, and never read from the configuration.
> Simply adding the folllowing code at Line 76 resolved issue.:
> {code:java}
> useIP = context.getConfig().getBoolean(ExecConstants.USE_IP_ADDRESS);
> {code}
> With the above code, the Drillbit is registerd in the quorum with the IP
> address, not the hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
