[
https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610039#comment-15610039
]
ASF GitHub Bot commented on DRILL-3510:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r85241100
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
@@ -760,6 +765,24 @@ public void abort(Executor executor) throws
SQLException {
}
}
+ @Override
+ public boolean useAnsiQuotedIdentifiers() throws SQLException {
+ boolean systemOption = false;
+ Boolean sessionOption = null;
+ String sql = String.format("select type, bool_val from sys.options
where name = '%s'",
+ PlannerSettings.ANSI_QUOTES_KEY);
+ ResultSet rs = executeSql(sql);
--- End diff --
the statement is not closed, same for the result set, so resources are
leaked.
Also, there's an ongoing effort to remove hand-made requests to query
metadata and replace those by rpc calls. Shouldn't we introduce a new RPC call
to query session state instead? (it also makes things easier for the C++
connector)
> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL
> identifiers
> --------------------------------------------------------------------------------------
>
> Key: DRILL-3510
> URL: https://issues.apache.org/jira/browse/DRILL-3510
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Reporter: Jinfeng Ni
> Assignee: Vitalii Diravka
> Fix For: Future
>
> Attachments: DRILL-3510.patch, DRILL-3510.patch
>
>
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as
> what MySQL does. However, this is different from ANSI SQL specification,
> where double quote is used as identifier quotes.
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user.
> Drill should follow the same way, so that Drill users do not have to rewrite
> their existing queries, if their queries use double quotes.
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
