[ 
https://issues.apache.org/jira/browse/DRILL-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615764#comment-15615764
 ] 

ASF GitHub Bot commented on DRILL-4972:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/633#discussion_r85557510
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
    @@ -295,7 +295,7 @@ public FragmentExecutor getFragmentRunner(final 
FragmentHandle handle) {
        */
       private class StatusThread extends Thread {
         public StatusThread() {
    -      setDaemon(true);
    +      setDaemon(false);
    --- End diff --
    
    Not sure why removing it will not ensure the same. I think it's redundant 
and like overriding a default already set in constructor with default value 
using setter method.


> Drillbit shuts down immediately after starting if embedded web server is 
> disabled
> ---------------------------------------------------------------------------------
>
>                 Key: DRILL-4972
>                 URL: https://issues.apache.org/jira/browse/DRILL-4972
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.8.0
>            Reporter: Sudheesh Katkam
>            Assignee: Sorabh Hamirwasia
>            Priority: Critical
>             Fix For: 1.9.0
>
>
> Disable embedded web server by setting "drill.exec.http.enabled" to false. 
> Now when drillbit is started, it shuts down immediately after starting.
> JVM exits when the only threads running are all daemon threads. Turns out all 
> threads in a drillbit, other than the thread pool started by the web server, 
> are daemon. So I suggest WorkManager#StatusThread be made non-daemon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to