[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623262#comment-15623262
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r85800948
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.hpp ---
@@ -564,6 +570,34 @@ class ZookeeperImpl{
std::string m_rootDir;
};
+class SaslAuthenticatorImpl {
+
+ public:
+
+ SaslAuthenticatorImpl(const DrillUserProperties* const properties);
+
+ ~SaslAuthenticatorImpl();
+
+ int init(std::vector<std::string> mechanisms, std::string
&chosenMech,
--- End diff --
use const reference as much as possible.
The API also mix up C and C++ types, maybe this class should only expose an
API based on C++ types, and manage the conversion from/to C types as a better
encapsulation model
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Chunhui Shi
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
