[
https://issues.apache.org/jira/browse/DRILL-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627398#comment-15627398
]
ASF GitHub Bot commented on DRILL-4706:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86062215
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
@@ -146,6 +153,32 @@ private AssignmentCreator(List<DrillbitEndpoint>
incomingEndpoints, List<T> unit
return currentUnassignedList;
}
+
+ private LinkedList<WorkEndpointListPair<T>>
assignLocal(List<WorkEndpointListPair<T>> workList,
+
Map<DrillbitEndpoint,FragIteratorWrapper> endpointIterators) {
+ LinkedList<WorkEndpointListPair<T>> currentUnassignedList =
Lists.newLinkedList();
+ for (WorkEndpointListPair<T> workPair : workList) {
+ DrillbitEndpoint endpoint = workPair.work.getPreferredEndpoint();
+ if (endpoint == null) {
+ currentUnassignedList.add(workPair);
+ continue;
+ }
+
+ FragIteratorWrapper iteratorWrapper =
endpointIterators.get(endpoint);
+ if (iteratorWrapper == null) {
+ currentUnassignedList.add(workPair);
+ continue;
+ }
+
+ Integer assignment = iteratorWrapper.iter.next();
+ iteratorWrapper.count++;
--- End diff --
Here shouldn't we check if the "iteratorWrapper.count" is exceeding the
"iteratorWrapper.maxCount" ?
> Fragment planning causes Drillbits to read remote chunks when local copies
> are available
> ----------------------------------------------------------------------------------------
>
> Key: DRILL-4706
> URL: https://issues.apache.org/jira/browse/DRILL-4706
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.6.0
> Environment: CentOS, RHEL
> Reporter: Kunal Khatua
> Assignee: Sorabh Hamirwasia
> Labels: performance, planning
>
> When a table (datasize=70GB) of 160 parquet files (each having a single
> rowgroup and fitting within one chunk) is available on a 10-node setup with
> replication=3 ; a pure data scan query causes about 2% of the data to be read
> remotely.
> Even with the creation of metadata cache, the planner is selecting a
> sub-optimal plan of executing the SCAN fragments such that some of the data
> is served from a remote server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
