[
https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636773#comment-15636773
]
ASF GitHub Bot commented on DRILL-4604:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/482#discussion_r86573607
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -17,17 +17,56 @@
<a href="/queries">back</a><br/>
<div class="page-header">
</div>
- <div class="table-responsive">
- <table class="table table-hover">
- <tbody>
- <#list model as stat>
- <tr>
- <td style="border:none;"><b>${stat.getName()}</b></td>
- <td style="border:none; font-family:
Courier;">${stat.getValue()}</td>
- </tr>
- </#list>
- </tbody>
- </table>
+
+ <#list model.getDrillbits() as drillbit>
+ <#if !drillbit.isVersionMatch()>
+ <div id="message" class="alert alert-danger alert-dismissable">
+ <button type="button" class="close" data-dismiss="alert"
aria-hidden="true">×</button>
+ <strong>Drillbits in the cluster have different versions.</strong>
+ </div>
+ <#break>
+ </#if>
+ </#list>
+
+ <div class="row">
+ <div class="col-md-6">
+ <h3>General Info</h3>
+ <div class="table-responsive">
+ <table class="table table-hover">
+ <tbody>
+ <#assign props = model.getProps()>
+ <#list props?keys as key>
+ <tr>
+ <td style="border:none;"><b>${key}</b></td>
+ <td style="border:none; font-family:
Courier;">${props[key]}</td>
+ </tr>
+ </#list>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="col-md-6">
+ <h3>List of Drillbits</h3>
+ <div class="table-responsive">
+ <table class="table table-hover">
+ <tbody>
+ <#assign i = 1>
+ <#list model.getDrillbits() as drillbit>
+ <tr>
+ <td style="border:none;"><b>Drillbit # ${i}</b></td>
+ <td style="border:none; font-family:
Courier;">${drillbit.getAddress()} ${drillbit.isInitialized()}</td>
+ <td style="border:none;">
+ <span class="label <#if
drillbit.isVersionMatch()>label-success<#else>label-danger</#if>">
+ <#if
(drillbit.getVersion())?has_content>${drillbit.getVersion()}<#else>Undefined</#if>
--- End diff --
Nice trick: ${drillbit.version()!"Undefined"}
The "!" says "if the preceding is defined and not null, use it, else use
the thing that comes next."
> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
> Key: DRILL-4604
> URL: https://issues.apache.org/jira/browse/DRILL-4604
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Arina Ielchiieva
> Assignee: Sudheesh Katkam
> Labels: doc-impacting
> Fix For: Future
>
> Attachments: index_page.JPG, index_page_mismatch.JPG,
> screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match
> with current drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
