[
https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636775#comment-15636775
]
ASF GitHub Bot commented on DRILL-4604:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/482#discussion_r86566500
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() {
}
/**
+ * If cluster version is the same as default, update option to current
drillbit version.
+ */
+ private void checkAndUpdateClusterVersionOption(OptionManager
optionManager, DrillbitEndpoint drillbitEndpoint) {
+ OptionValue versionOption =
optionManager.getOption(ExecConstants.CLUSTER_VERSION);
+ OptionValidator validator =
SystemOptionManager.getValidator(ExecConstants.CLUSTER_VERSION);
+ if (versionOption.equals(validator.getDefault())) {
+ optionManager.setOption(OptionValue.createOption(
--- End diff --
I'm not convinced that having the admin specify the cluster option is the
right approach. The proper approach is for each Drillbit to detect that its own
version conflicts with one or more of the others. But, for this to work,
Drillbits have to advertise their version. Do we have that ability?
> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
> Key: DRILL-4604
> URL: https://issues.apache.org/jira/browse/DRILL-4604
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Arina Ielchiieva
> Assignee: Sudheesh Katkam
> Labels: doc-impacting
> Fix For: Future
>
> Attachments: index_page.JPG, index_page_mismatch.JPG,
> screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match
> with current drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
