[
https://issues.apache.org/jira/browse/DRILL-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638264#comment-15638264
]
Jinfeng Ni commented on DRILL-4911:
-----------------------------------
[~kkhatua], [~knguyen], it's probably not easy to verify this patch from
functional perspective. Before and after the patch, in both cases, Drill does
not write anything under no-debug mode. The difference is before the patch
Drill will serialize the plan into heap memory, then check if it's debug mode
to decide if it should be logged. With the patch, it first checks if it's debug
mode to decide if serialization is needed or not.
> SimpleParallelizer should avoid plan serialization for logging purpose when
> debug logging is not enabled.
> ---------------------------------------------------------------------------------------------------------
>
> Key: DRILL-4911
> URL: https://issues.apache.org/jira/browse/DRILL-4911
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Priority: Minor
> Fix For: 1.9.0
>
>
> SimpleParallelizer and subclass have code to put serialized plan in debug
> log. However, in case when the physical plan fragment is very large (table is
> huge with large # of partitions, files, etc), the overhead of serialization
> is not negligible. The code seems to always do serialization, regardless
> whether the debug flag is turned on.
> To reduce the overhead, SimpleParallelizer and subclass should only do plan
> serialization for logging purpose when debug logging is turned on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
