[ 
https://issues.apache.org/jira/browse/DRILL-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676648#comment-15676648
 ] 

Hongze Zhang edited comment on DRILL-5051 at 11/18/16 4:27 PM:
---------------------------------------------------------------

Hi Khurram,

I personally guess that the method *void limitWithSV(int recordCount)* has a 
little problem, although I still don't understand why the author made different 
behaviors in two limit methods (limitWithSV and limitWithNoSV).

I did a quick fix in [https://github.com/apache/drill/pull/658] including 
merging two methods. You can help check if the fix is appropriate. 


was (Author: zbdzzg):
Hi Khurram,

I personally guess that the method *void limitWithSV(int recordCount)* has a 
little problem, although I still don't understand why the author made different 
behavior in two limit methods (limitWithSV and limitWithNoSV).

I did a quick fix in [https://github.com/apache/drill/pull/658] including 
merging two methods. You can help check if the fix is appropriate. 

> Returning incorrect number of rows while querying using both nested select 
> and offset
> -------------------------------------------------------------------------------------
>
>                 Key: DRILL-5051
>                 URL: https://issues.apache.org/jira/browse/DRILL-5051
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.8.0
>         Environment: Fedora 24 / OpenJDK 8
>            Reporter: Hongze Zhang
>            Assignee: Sudheesh Katkam
>             Fix For: Future
>
>
> My SQl:
> select count(1) from (select id from (select id from 
> cp.`tpch/lineitem.parquet` LIMIT 2) limit 1 offset 1) 
> This SQL returns nothing.
> Something goes wrong in LimitRecordBatch.java, and the reason is different 
> with [DRILL-4884|https://issues.apache.org/jira/browse/DRILL-4884?filter=-2]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to