[ 
https://issues.apache.org/jira/browse/DRILL-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687203#comment-15687203
 ] 

Paul Rogers commented on DRILL-5058:
------------------------------------

Putting this on hold. Seems the original behavior may work. The actual problem 
may be that ESB has multiple ways of handling exceptions; it is not entirely 
clear which is the "proper" way.

> External sort does not handle its own UserExceptions
> ----------------------------------------------------
>
>                 Key: DRILL-5058
>                 URL: https://issues.apache.org/jira/browse/DRILL-5058
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>
> The external sort throws a {{UserException}} in a variety of conditions: 
> error during spilling, on out-of-memory on SV2 allocation, and on a schema 
> change.
> However, except for the schema change, the external sort does not *handle* 
> the exceptions that it throws. In part this is because {{UserException}} is 
> unchecked, so the code is not obligated to handle it. By handle, here we mean 
> clean up resources, send a {{IterOutcome.STOP}} result to the downstream 
> operator, etc.
> The fix is to add a catch for {{UserException}} to the block of catches in 
> {{innerNext()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to