[
https://issues.apache.org/jira/browse/DRILL-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692570#comment-15692570
]
ASF GitHub Bot commented on DRILL-5054:
---------------------------------------
Github user zbdzzg commented on a diff in the pull request:
https://github.com/apache/drill/pull/663#discussion_r89448653
--- Diff: exec/java-exec/src/main/resources/rest/query/result.ftl ---
@@ -11,14 +11,13 @@
<#include "*/generic.ftl">
<#macro page_head>
- <link rel="stylesheet" type="text/css"
href="//code.jquery.com/ui/1.10.3/themes/smoothness/jquery-ui.css">
- <link rel="stylesheet" type="text/css"
href="//cdn.datatables.net/plug-ins/be7019ee387/integration/jqueryui/dataTables.jqueryui.css">
+ <link rel="stylesheet" type="text/css" href="/static/css/jquery-ui.css">
--- End diff --
Hi Parthchandra,
I have reconsidered this.
Simply putting these things to source code is indeed not a graceful
solution, even this method is just temporarily working in my case.
I agree with your second advice: to make these stuffs downloadable and
configurable. But as the typical scene for now is that users can already have
them in cache, so may be just customizing and recompiling the code for special
requirements like this is more reasonable for users like me (the scripts are
not fetchable from my area, the network hangs while accessing cdn, util click
"stop" actively. To have both the cdn and local files is therefore not work for
me), I am so going to shelve this issue util someone report the same problem.
Thank you.
> Provide jquery-ui and jquery-dataTables locally
> -----------------------------------------------
>
> Key: DRILL-5054
> URL: https://issues.apache.org/jira/browse/DRILL-5054
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.8.0
> Environment: Fedora 24 / OpenJDK 8 / FireFox 50.0
> Reporter: Hongze Zhang
> Fix For: Future
>
>
> Hi,
> Currently Drill uses CDN for serving source files of jquery-ui and
> jquery-dataTables. This is OK for most cases, but not working in an isolated
> environment.
> This is a patch adding these files so that Drill will work fine in intranet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
