[
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724526#comment-15724526
]
ASF GitHub Bot commented on DRILL-4956:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91016983
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
---
@@ -82,6 +84,9 @@ public void init(Map<String, String> writerOptions)
throws IOException {
Path fileName = new Path(location, prefix + "_" + index + "." +
extension);
try {
stream = fs.create(fileName);
+ // set storage strategy for folder and file
+ storageStrategy.apply(fs, fileName.getParent());
+ storageStrategy.apply(fs, fileName);
--- End diff --
Hmmm... The strategy has permission of "775" (permanent) and "700"
(temporary). Those include executable. May be fine for the directory. Not so
good for the data file. Maybe need an applyToFile and applyToDir? Or, let the
storage strategy split the name?
Also, it is not clear if we are creating the directory here, or just
changing an existing one. Seems we should honor existing perms on existing
dirs; but set then only on new dirs. So, maybe have a mkdir() method that works
like mkdirs(): create dir if needed (and imply permissions) or do nothing if
the directory exists.
Does writer here create a directory? Will we know to remove it at end of
session? We set delete on exit, but exit may be weeks away (for a long-lived
Drillbit). Do we know to cascade deletes down into directories if the writer
creates a partitioned file?
> Temporary tables support
> ------------------------
>
> Key: DRILL-4956
> URL: https://issues.apache.org/jira/browse/DRILL-4956
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Arina Ielchiieva
> Assignee: Paul Rogers
> Labels: doc-impacting
> Fix For: Future
>
>
> Link to design doc -
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
