[
https://issues.apache.org/jira/browse/DRILL-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727945#comment-15727945
]
ASF GitHub Bot commented on DRILL-5112:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/681#discussion_r91236287
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/pop/PopUnitTestBase.java ---
@@ -42,7 +46,17 @@
@BeforeClass
public static void setup() {
- CONFIG = DrillConfig.create();
+ Properties props = new Properties();
--- End diff --
Per the TypeSafe config system, command line properties override any
properties here or in drill-module.conf.
> Unit tests derived from PopUnitTestBase fail in IDE due to config errors
> ------------------------------------------------------------------------
>
> Key: DRILL-5112
> URL: https://issues.apache.org/jira/browse/DRILL-5112
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
>
> Drill provides a wide variety of unit tests. Many derive from
> {{PopUnitTestBase}} to test the Physical OPerators.
> The tests use a default configuration:
> {code}
> protected static DrillConfig CONFIG;
> @BeforeClass
> public static void setup() {
> CONFIG = DrillConfig.create();
> }
> {code}
> The tests rely on config settings specified in the {{pom.xml}} file (see note
> below.) When run in Eclipse, no such config exists, so the tests use only the
> default config. The defaults allow a web server to be started.
> Many tests start multiple Drillbits using the above config. When this occurs,
> each tries to start a web server. The second one fails because the HTTP port
> is already in use.
> The solution is to initialize the config using the same settings as used in
> the {{BaseTestQuery}} test case: the unit tests then work fine in Eclipse.
> As an aside, having multiple ways to set up the Drill config (and other
> items) leads to much wasted time as each engineer must learn the quirks of
> each test hierarchy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
