[ 
https://issues.apache.org/jira/browse/DRILL-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730662#comment-15730662
 ] 

ASF GitHub Bot commented on DRILL-5091:
---------------------------------------

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91422118
  
    --- Diff: 
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
 ---
    @@ -477,18 +477,32 @@ public void testClosedConnectionMethodsThrowRight() {
         }
     
         @Override
    +    protected boolean isOkayNonthrowingMethod(Method method) {
    +      // Java 8 method
    +      if ( "getLargeUpdateCount".equals(method.getName())) {
    +        return true; }
    +      return super.isOkayNonthrowingMethod(method);
    +    }
    +
    +    @Override
         protected boolean isOkaySpecialCaseException(Method method, Throwable 
cause) {
           final boolean result;
           if (super.isOkaySpecialCaseException(method, cause)) {
             result = true;
           }
    +      else if (   method.getName().equals("executeLargeBatch")
    --- End diff --
    
    remove extra space after if. 


> JDBC unit test fail on Java 8
> -----------------------------
>
>                 Key: DRILL-5091
>                 URL: https://issues.apache.org/jira/browse/DRILL-5091
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>         Environment: Java 8
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>
> Run the {{TestJDBCQuery}} unit tests. They will fail with errors relating to 
> the default name space.
> The problem is due to a failure (that is ignored, DRILL-5090) to set up the 
> test DFS name space.
> The "dfs_test" storage plugin is not found in the plugin registry, resulting 
> in a null object and NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to