[
https://issues.apache.org/jira/browse/DRILL-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786069#comment-15786069
]
Paul Rogers commented on DRILL-5168:
------------------------------------
Thanks for the note. Most operators have one or more unit tests in
{{src/test/java}} that correspond to the implementations in {{src/main/java}}.
The streaming aggregate does not.
While one could search all of Drill for cases that have, as a side effect,
testing of this operator, this is a huge inconvenience. At the very least,
insert a text file in the streaming agg test package that says, "This operator
is too simple to test directly. Please use the following tests instead: x, y,
z."
Testing is a "good thing". We should a) have tests, and b) make them easily
available to developers to use when we muck about with the code.
> No direct Streaming Agg test cases
> ----------------------------------
>
> Key: DRILL-5168
> URL: https://issues.apache.org/jira/browse/DRILL-5168
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Priority: Minor
>
> Drill's provides both hash and streaming aggregate operators. Both reside in
> the {{org.apache.drill.exec.physical.impl.aggregate}} package. The
> corresponding test package contains tests only for the hash aggregate:
> {{TestHashAggr}}. No corresponding unit tests exists for streaming aggregates.
> It may be that other, SQL-level tests have the effect of testing streaming
> aggregates (but I've not yet found such tests.) Without unit tests, we cannot
> guarantee that changes to streaming aggregates will work correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
