[
https://issues.apache.org/jira/browse/DRILL-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800201#comment-15800201
]
ASF GitHub Bot commented on DRILL-5116:
---------------------------------------
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94697603
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java
---
@@ -119,13 +119,18 @@ public ClassCompilerSelector(ClassLoader classLoader,
DrillConfig config, Option
byte[][] bc = getCompiler(sourceCode).getClassByteCode(className,
sourceCode);
// Uncomment the following to save the generated byte codes.
-
-// final String baseDir = System.getProperty("java.io.tmpdir") +
File.separator + className;
-// File classFile = new File(baseDir + className.clazz);
-// classFile.getParentFile().mkdirs();
-// try (BufferedOutputStream out = new BufferedOutputStream(new
FileOutputStream(classFile))) {
-// out.write(bc[0]);
+ // Use the JDK javap command to view the generated code.
+ // This is the code from the compiler before byte code manipulations.
--- End diff --
Maybe add a comment that for the "after BC manipulations" see similar code
in QueryClassLoader.java .
> Enable generated code debugging in each Drill operator
> ------------------------------------------------------
>
> Key: DRILL-5116
> URL: https://issues.apache.org/jira/browse/DRILL-5116
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.9.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> DRILL-5052 adds the ability to debug generated code. Some of the code
> generated by Drill's operators has minor problems when compiled directly
> using the new technique. These issues are ignore by the byte-code-merge
> technique uses in production. This ticket asks to try the DRILL-5052 feature
> in each operator, clean up any minor problems, and ensure each operator
> generates code suitable for debugging. Use the new
> {{CodeGenerator.plainOldJavaCapable()}} method to mark each generated class
> as ready for "plain-old Java" code gen.
> The advantages of this feature are two:
> 1. Ability to step through the generated code to increase understanding of
> existing operators and to ease development of improvements to existing
> operators and of any new operators we choose to create.
> 2. Open the door to experimenting with how to improve performance of the
> generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
