[
https://issues.apache.org/jira/browse/DRILL-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806377#comment-15806377
]
ASF GitHub Bot commented on DRILL-5116:
---------------------------------------
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95040108
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
---
@@ -76,6 +75,22 @@
String textFileContent;
+ @BeforeClass
+ public static void setup( ) {
+ // Tests here rely on the byte-code merge approach to code
+ // generation and will fail if using plain-old Java.
+ // Actually, some queries succeed with plain-old Java that
+ // fail with scalar replacement, but the tests check for the
+ // scalar replacement failure and, not finding it, fail the
+ // test.
+ //
+ // The setting here forces byte-code merge even if the
+ // config file asks for plain-old Java.
+ // TODO: Fix the tests to handle both cases.
+
+ System.setProperty("drill.compile.prefer_plain_java", "false");
--- End diff --
Same as above comment.
> Enable generated code debugging in each Drill operator
> ------------------------------------------------------
>
> Key: DRILL-5116
> URL: https://issues.apache.org/jira/browse/DRILL-5116
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.9.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Labels: ready-to-commit
>
> DRILL-5052 adds the ability to debug generated code. Some of the code
> generated by Drill's operators has minor problems when compiled directly
> using the new technique. These issues are ignore by the byte-code-merge
> technique uses in production. This ticket asks to try the DRILL-5052 feature
> in each operator, clean up any minor problems, and ensure each operator
> generates code suitable for debugging. Use the new
> {{CodeGenerator.plainOldJavaCapable()}} method to mark each generated class
> as ready for "plain-old Java" code gen.
> The advantages of this feature are two:
> 1. Ability to step through the generated code to increase understanding of
> existing operators and to ease development of improvements to existing
> operators and of any new operators we choose to create.
> 2. Open the door to experimenting with how to improve performance of the
> generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
