[
https://issues.apache.org/jira/browse/DRILL-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815997#comment-15815997
]
ASF GitHub Bot commented on DRILL-5116:
---------------------------------------
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/716
In the current code generator, we log both the source code and the size of
source / byte code, the time spent on compiling, and the complier (Janino vs
JDK) at debug level. It's probably debatable to log the source code, but the
other information is quite useful for analyzing customer issue. In the
plain-old style generator, seems we do not put those information in debug log.
For now, the patch is not enabled. But in the future, if we are going to use
this new code generator in production, we had better log more information(
either in the log, or in operator profile), as that will help improve service
workload.
> Enable generated code debugging in each Drill operator
> ------------------------------------------------------
>
> Key: DRILL-5116
> URL: https://issues.apache.org/jira/browse/DRILL-5116
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.9.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Labels: ready-to-commit
>
> DRILL-5052 adds the ability to debug generated code. Some of the code
> generated by Drill's operators has minor problems when compiled directly
> using the new technique. These issues are ignore by the byte-code-merge
> technique uses in production. This ticket asks to try the DRILL-5052 feature
> in each operator, clean up any minor problems, and ensure each operator
> generates code suitable for debugging. Use the new
> {{CodeGenerator.plainOldJavaCapable()}} method to mark each generated class
> as ready for "plain-old Java" code gen.
> The advantages of this feature are two:
> 1. Ability to step through the generated code to increase understanding of
> existing operators and to ease development of improvements to existing
> operators and of any new operators we choose to create.
> 2. Open the door to experimenting with how to improve performance of the
> generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
