[
https://issues.apache.org/jira/browse/DRILL-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829237#comment-15829237
]
ASF GitHub Bot commented on DRILL-5126:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96785539
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -57,20 +166,36 @@
private final int records;
private final int batches;
private final long ms;
+ private final QueryState finalState;
+ private final Exception error;
- public QuerySummary(QueryId queryId, int recordCount, int batchCount,
long elapsed) {
+ public QuerySummary(QueryId queryId, int recordCount, int batchCount,
long elapsed, QueryState state) {
this.queryId = queryId;
records = recordCount;
batches = batchCount;
ms = elapsed;
+ finalState = state;
+ error = null;
}
- public long recordCount( ) { return records; }
- public int batchCount( ) { return batches; }
- public long runTimeMs( ) { return ms; }
- public QueryId queryId( ) { return queryId; }
- public String queryIdString( ) { return
QueryIdHelper.getQueryId(queryId); }
+ public QuerySummary(QueryId queryId, int recordCount, int batchCount,
long elapsed, Exception ex) {
+ this.queryId = queryId;
+ records = recordCount;
+ batches = batchCount;
+ ms = elapsed;
+ finalState = null;
+ error = ex;
+ }
+ public boolean failed() { return error != null; }
+ public boolean succeeded() { return error == null; }
--- End diff --
formatting here ?
> Provide simplified, unified "cluster fixture" for tests
> -------------------------------------------------------
>
> Key: DRILL-5126
> URL: https://issues.apache.org/jira/browse/DRILL-5126
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.9.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> Drill provides a robust selection of test frameworks that have evolved to
> satisfy the needs of a variety of test cases. For newbies, however, the
> result is a bewildering array of ways to do basically the same thing: set up
> an embedded Drill cluster, run queries and check results.
> Further, some key test settings are distributed: some are in the pom.xml
> file, some in config files stored as resources, some in hard-coded settings
> in base test classes.
> Also, some test base classes helpfully set up a test cluster, but then
> individual tests need a different config, so they immediately tear down the
> default cluster and create a new one.
> This ticket proposes a new test framework, available for new tests, that
> combines the best of the existing test frameworks into a single, easy-to-use
> package.
> * Builder for the cluster
> * Accept config-time options
> * Accept run-time session and system options
> * Specify number of Drillbits
> * Simplified API for the most common options
> * AutoCloseable for use in try-with-resources statements
> * Integration with existing test builder classes
> And so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
