[ 
https://issues.apache.org/jira/browse/DRILL-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836746#comment-15836746
 ] 

ASF GitHub Bot commented on DRILL-5218:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/726#discussion_r97663988
  
    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -1400,22 +1404,6 @@ void DrillClientImpl::handleRead(ByteBuf_t _buf,
                 break;
     
             case exec::user::HANDSHAKE:
    --- End diff --
    
    maybe you can also remove the case statement


> Support Disabling Heartbeats in C++ Client
> ------------------------------------------
>
>                 Key: DRILL-5218
>                 URL: https://issues.apache.org/jira/browse/DRILL-5218
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>
> Heartbeats between bits allow for detecting health of remotes, but heartbeats 
> between client and bit may not be necessary? So allow to (at least) disable 
> heartbeats between C++ client and bit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to