[
https://issues.apache.org/jira/browse/DRILL-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851961#comment-15851961
]
ASF GitHub Bot commented on DRILL-5240:
---------------------------------------
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/740
+1
LGTM
> Parquet reader creates unnecessary objects when checking for nullability in
> var length columns
> ----------------------------------------------------------------------------------------------
>
> Key: DRILL-5240
> URL: https://issues.apache.org/jira/browse/DRILL-5240
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Parquet
> Reporter: Parth Chandra
> Assignee: Parth Chandra
>
> In {{NullableVarLengthValuesColumn.java}} we have the following line of code:
> {code}
> currentValNull =
> variableWidthVector.getAccessor().getObject(valuesReadInCurrentPass) == null;
> {code}
> which creates an object to check nullability of every (nullable var char)
> value being read. This object creation is expensive and can be replaced with
> a simple check for the null bit.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
