[ 
https://issues.apache.org/jira/browse/DRILL-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854173#comment-15854173
 ] 

ASF GitHub Bot commented on DRILL-5040:
---------------------------------------

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/744

    DRILL-5040: Parquet writer unable to delete table folder on abort

    Folder directory clean up failed because couldn't delete the directory:
    `java.io.IOException: Directory 
/tmp/446062ea-46ae-4785-98e3-0ee23df9ead5/3c6d40ff-31f2-419e-a178-d9c5fd731e11 
is not empty`. Replaced in `fs.delete(location, true)` recursive flag to `true` 
 to allow directory deletion.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5040

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
    
----
commit cd9779e8b2e3efe995010e2e91620429ff019210
Author: Arina Ielchiieva <[email protected]>
Date:   2017-02-06T13:11:02Z

    DRILL-5040: Parquet writer unable to delete table folder on abort

----


> Interrupted CTAS should not succeed & should not create physical file on disk
> -----------------------------------------------------------------------------
>
>                 Key: DRILL-5040
>                 URL: https://issues.apache.org/jira/browse/DRILL-5040
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.9.0
>            Reporter: Khurram Faraaz
>            Assignee: Arina Ielchiieva
>             Fix For: 1.10.0
>
>
> We should not allow CTAS to succeed (i.e create physical file on disk ) in 
> the case where it was interrupted. (vis Ctrl-C)
> Drill 1.9.0
> git commit ID : db30854
> Consider the below CTAS that was interrupted using Ctrl-C
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> create table temp_t1 as select * from 
> `twoKeyJsn.json`; 
> [ issue Ctrl-C while the above CTAS is running ]
> No rows affected (7.694 seconds)
> {noformat}
> I verified that physical file was created on disk, even though the above CTAS 
> was Canceled
> {noformat}
> [root@centos-01 ~]# hadoop fs -ls /tmp/temp_t1*
> -rwxr-xr-x   3 root root   36713198 2016-11-14 10:51 
> /tmp/temp_t1/0_0_0.parquet
> {noformat}
> We are able to do a select on the CTAS table (above) that was Canceled.
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from temp_t1;
> +----------+
> |  EXPR$0  |
> +----------+
> | 3747840  |
> +----------+
> 1 row selected (0.183 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to