[
https://issues.apache.org/jira/browse/DRILL-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862158#comment-15862158
]
ASF GitHub Bot commented on DRILL-5252:
---------------------------------------
GitHub user lifove opened a pull request:
https://github.com/apache/drill/pull/745
DRILL-5252: Fix a condition that always returns true
Fix for https://issues.apache.org/jira/browse/DRILL-5252
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lifove/drill DRILL-5252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #745
----
commit e9ac4c189dd25b224fe45cfa6ebe155ce45f3bf2
Author: JC <[email protected]>
Date: 2017-02-11T02:08:00Z
DRILL-5252: Fix a condition that always returns true
----
> A condition returns always true
> -------------------------------
>
> Key: DRILL-5252
> URL: https://issues.apache.org/jira/browse/DRILL-5252
> Project: Apache Drill
> Issue Type: Bug
> Reporter: JC
> Priority: Minor
>
> I've found the following code smell in recent github snapshot.
> Path:
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
> {code:java}
> 287
> 288 @Override
> 289 public Boolean visitNullConstant(TypedNullConstant e, LogicalExpression
> value) throws RuntimeException {
> 290 if (!(value instanceof TypedNullConstant)) {
> 291 return false;
> 292 }
> 293 return e.getMajorType().equals(e.getMajorType());
> 294 }
> 295
> {code}
> Should it be like this?
> {code:java}
> 292 }
> 293 return value.getMajorType().equals(e.getMajorType());
> 294 }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
