[
https://issues.apache.org/jira/browse/DRILL-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869096#comment-15869096
]
ASF GitHub Bot commented on DRILL-5242:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/742#discussion_r101440816
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -163,11 +165,18 @@ public String getMetricsTable() {
null);
final Number[] values = new Number[metricNames.length];
+ //Track new/Unknown Metrics
+ final Set<Integer> unknownMetrics = new TreeSet<Integer>();
for (final MetricValue metric : op.getMetricList()) {
- if (metric.hasLongValue()) {
- values[metric.getMetricId()] = metric.getLongValue();
- } else if (metric.hasDoubleValue()) {
- values[metric.getMetricId()] = metric.getDoubleValue();
+ if (metric.getMetricId() < metricNames.length) {
+ if (metric.hasLongValue()) {
+ values[metric.getMetricId()] = metric.getLongValue();
+ } else if (metric.hasDoubleValue()) {
+ values[metric.getMetricId()] = metric.getDoubleValue();
+ }
+ } else {
+ //Tracking unknown metric IDs
+ unknownMetrics.add(metric.getMetricId());
--- End diff --
Sure. Still not convinced we need to build a map to throw away, but I guess
doing so, while silly, is harmless.
> The UI breaks when trying to render profiles having unknown metrics
> -------------------------------------------------------------------
>
> Key: DRILL-5242
> URL: https://issues.apache.org/jira/browse/DRILL-5242
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Fix For: 1.10.0
>
>
> When profiles are generated using a fork of Drill that has introduced new
> metrics, the server of the parent branch will fail in rendering the operator
> metrics correctly.
> The workaround should be to simply skip unknown metrics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
