[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877160#comment-15877160
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r101631177
--- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java ---
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.common;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.base.Preconditions.checkState;
+
+public final class KerberosUtil {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(KerberosUtil.class);
+
+ public static final String KERBEROS_SASL_NAME = "GSSAPI";
+
+ public static final String KERBEROS_SIMPLE_NAME = "KERBEROS";
+
+ public static final String HOSTNAME_PATTERN = "_HOST";
+
+ /**
+ * Returns principal of format primary/instance@REALM.
+ *
+ * @param primary non-null primary component
+ * @param instance non-null instance component
+ * @param realm non-null realm component
+ * @return principal of format primary/instance@REALM
+ */
+ public static String getPrincipalFromParts(final String primary, final
String instance, final String realm) {
+ return checkNotNull(primary) + "/" +
+ checkNotNull(instance) + "@" +
+ checkNotNull(realm);
+ }
+
+ /**
+ * Expects principal of the format primary/instance@REALM.
+ *
+ * @param principal principal
+ * @return components
+ */
+ public static String[] splitPrincipalIntoParts(final String principal) {
+ final String[] components = principal.split("[/@]");
+ checkState(components.length == 3);
+ checkNotNull(components[0]);
+ checkNotNull(components[1]);
+ checkNotNull(components[2]);
+ return components;
+ }
+
+ public static String canonicalizedInstanceName(String instanceName,
final String canonicalName) {
--- End diff --
(style) for consistency, use verb present tense for methods
(canonicalizeInstanceName)
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Sudheesh Katkam
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)