[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877134#comment-15877134
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r102292416
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java
---
@@ -105,8 +128,83 @@ protected void finalizeConnection(BitControlHandshake
handshake, ControlConnecti
connection.setEndpoint(handshake.getEndpoint());
}
- public ControlConnection getConnection() {
- return this.connection;
+ @Override
+ protected <M extends MessageLite> RpcCommand<M, ControlConnection>
+ getInitialCommand(final RpcCommand<M, ControlConnection> command) {
+ if (config.getAuthMechanismToUse() == null) {
+ return super.getInitialCommand(command);
+ } else {
+ return new AuthenticationCommand<>(command);
--- End diff --
shouldn't we use `super.getInitialCommand(command)` too?
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Sudheesh Katkam
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
