[
https://issues.apache.org/jira/browse/DRILL-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881486#comment-15881486
]
ASF GitHub Bot commented on DRILL-5195:
---------------------------------------
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102839683
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent() {
maxRecords = Math.max(sp.getRecords(), maxRecords);
}
- builder.appendFormattedInteger(maxBatches, null);
- builder.appendFormattedInteger(maxRecords, null);
- builder.appendBytes(op.getPeakLocalMemoryAllocated(), null);
+ builder.appendFormattedInteger(maxBatches, null, null);
+ builder.appendFormattedInteger(maxRecords, null, null);
+ builder.appendBytes(op.getPeakLocalMemoryAllocated(), null, null);
}
return builder.build();
}
- public static final String[] OPERATORS_OVERVIEW_COLUMNS = {"Operator
ID", "Type", "Min Setup Time", "Avg Setup Time",
- "Max Setup Time", "Min Process Time", "Avg Process Time", "Max Process
Time", "Min Wait Time", "Avg Wait Time",
- "Max Wait Time", "Avg Peak Memory", "Max Peak Memory"};
+ public static final String[] OPERATORS_OVERVIEW_COLUMNS = {"Operator
ID", "Type",
+ "Avg Setup Time", "Max Setup Time",
+ "Avg Process Time", "Max Process Time", "Min Wait Time", "Avg Wait
Time", "Max Wait Time",
+ "% Fragment Time", "% Query Time", "Rows",
+ "Avg Peak Memory", "Max Peak Memory"};
- public void addSummary(TableBuilder tb) {
+ public static final String[] OPERATORS_OVERVIEW_COLUMNS_TOOLTIP = {null,
null,
+ null, null, null, null, null, null, null,
+ "% of time that the major fragment spent in operator", "% of Query
time spent in operator", "Records emitted by the operator",
--- End diff --
Rows emitted would be correct. For all the operators, this is a tally of
the outgoing rows and not the rows processed.
Changed text for the rest.
> Publish Operator and MajorFragment Stats in Profile page
> --------------------------------------------------------
>
> Key: DRILL-5195
> URL: https://issues.apache.org/jira/browse/DRILL-5195
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Attachments: dbit_complete.png, dbit_inflight.png, dbit_opOverview.png
>
>
> Currently, we show runtimes for major fragments, and min,max,avg times for
> setup, processing and waiting for various operators.
> It would be worthwhile to have additional stats for the following:
> MajorFragment
> %Busy - % of the active time for all the minor fragments within each major
> fragment that they were busy.
> Operator Profile
> %Busy - % of the active time for all the fragments within each operator
> that they were busy.
> Records - Total number of records propagated out by that operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
