[
https://issues.apache.org/jira/browse/DRILL-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882545#comment-15882545
]
ASF GitHub Bot commented on DRILL-5255:
---------------------------------------
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/759
DRILL-5255: Remove default temporary workspace check at drillbit star…
…t up
Check if default temporary workspace is valid (exists, file-based and
writable) will be performed only if we attempt to create / drop temporary
table, this will allow users who don't use temporary tables successfully use
drill functionality even if default temporary workspace is not valid.
1. Removed default temporary workspace validity check at drillbit start up.
2. Ensured that default temporary workspace validity checks are only
performed when user tries to create / drop temporary tables.
3. Replaced PARSE errors to VALIDATION ones if workspace is not valid (for
CTAS tables).
4. Minor refactoring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-5255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #759
----
commit f49af5ac9a68299e4ae219797d82a7009beba359
Author: Arina Ielchiieva <[email protected]>
Date: 2017-02-22T18:13:14Z
DRILL-5255: Remove default temporary workspace check at drillbit start up
----
> Unit tests fail due to CTTAS temporary name space checks
> --------------------------------------------------------
>
> Key: DRILL-5255
> URL: https://issues.apache.org/jira/browse/DRILL-5255
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Arina Ielchiieva
> Fix For: 1.10.0
>
>
> Drill can operate in embedded mode. In this mode, no storage plugin
> definitions other than the defaults may be present. In particular, when using
> the Drill test framework, only those storage plugins defined in the Drill
> code are available.
> Yet, Drill checks for the existence of the dfs.tmp plugin definition (as
> named by the {{drill.exec.default_temporary_workspace}} parameter. Because
> this plugin is not defined, an exception occurs:
> {code}
> org.apache.drill.common.exceptions.UserException: PARSE ERROR: Unable to
> create or drop tables/views. Schema [dfs.tmp] is immutable.
> [Error Id: 792d4e5d-3f31-4f38-8bb4-d108f1a808f6 ]
> at
> org.apache.drill.common.exceptions.UserException$Builder.build(UserException.java:544)
> at
> org.apache.drill.exec.planner.sql.SchemaUtilites.resolveToMutableDrillSchema(SchemaUtilites.java:184)
> at
> org.apache.drill.exec.planner.sql.SchemaUtilites.getTemporaryWorkspace(SchemaUtilites.java:201)
> at
> org.apache.drill.exec.server.Drillbit.validateTemporaryWorkspace(Drillbit.java:264)
> at org.apache.drill.exec.server.Drillbit.run(Drillbit.java:135)
> at
> org.apache.drill.test.ClusterFixture.startDrillbits(ClusterFixture.java:207)
> ...
> {code}
> Expected that either a configuration would exist that would use the default
> /tmp/drill location, or that the check for {{drill.tmp}} would be deferred
> until it is actually required (such as when executing a CTTAS statement.)
> It seemed that the test framework must be altered to work around this problem
> by defining the necessary workspace. Unfortunately, the Drillbit must start
> before we can define the workspace needed for the Drillbit to start. So, this
> workaround is not possible.
> Further, users of the embedded Drillbit may not know to do this configuration.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
