[
https://issues.apache.org/jira/browse/DRILL-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883498#comment-15883498
]
ASF GitHub Bot commented on DRILL-5114:
---------------------------------------
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/762
DRILL-5114: Rationalize use of Logback logging in unit tests
Renamed logback.xml file used for testing to logback-test.xml as per
the Logback documentation. Made logging less detailed in the test
version to reduce verbose output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5114b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit dc98f5e5c5a1397f3f47ea9bfca36257db07b1f3
Author: Paul Rogers <prog...@maprtech.com>
Date: 2017-02-24T20:57:25Z
DRILL-5114: Rationalize use of Logback logging in unit tests
Renamed logback.xml file used for testing to logback-test.xml as per
the Logback documentation. Made logging less detailed in the test
version to reduce verbose output.
----
> Rationalize use of Logback logging in unit tests
> ------------------------------------------------
>
> Key: DRILL-5114
> URL: https://issues.apache.org/jira/browse/DRILL-5114
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> Drill uses Logback as its logger. The logger is used in several to display
> some test output. Test output is sent to stdout, rather than a log file.
> Since Drill also uses Logback, that same configuration sends much Drill
> logging output to stdout as well, cluttering test output.
> Logback requires that that one Logback config file (either logback.xml or
> hogback-test.xml) exist on the class path. Tests store the config file in the
> src/test/resources folder of each sub-project.
> These files set the default logging level to debug. While this setting is
> fine when working with individual tests, the output is overwhelming for bulk
> test runs.
> The first requested change is to set the default logging level to error.
> The existing config files are usually called "logback.xml." Change the name
> of test files to "logback-test.xml" to make clear that they are, in fact,
> test configs.
> The {{exec/java-exec/src/test/resources/logback.xml}} config file is a full
> version of Drill's production config file. Replace this with a config
> suitable for testing (that is, the same as other modules.)
> The java-exec project includes a production-like config file in its non-test
> sources: {{exec/java-exec/src/main/resources/logback.xml}}. Remove this as it
> is not needed. (Instead, rely on the one shipped in the distribution
> subsystem, which is the one copied to the Drill distribution.)
> Since Logback complains bitterly (via many log messages) when it cannot find
> a configuration file (and each sub-module must have its own test
> configuration), add missing logging configuration files:
> * exec/memory/base/src/test/resources/logback-test.xml
> * logical/src/test/resources/logback-test.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
