[
https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884828#comment-15884828
]
ASF GitHub Bot commented on DRILL-5208:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/763#discussion_r103110888
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -367,12 +375,18 @@ if [ -z "$JAVA_HOME" ]; then
fi
# Now, verify that 'java' binary exists and is suitable for Drill.
-if $is_cygwin; then
- JAVA_BIN="java.exe"
-else
- JAVA_BIN="java"
+# If we started with `which java` above, use that path (after replacing
+# symlinks. If we started with JAVA_HOME, try in bin. Doing so handles
--- End diff --
Close the brace.
> Finding path to java executable should be deterministic
> -------------------------------------------------------
>
> Key: DRILL-5208
> URL: https://issues.apache.org/jira/browse/DRILL-5208
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.10.0
> Reporter: Krystal
> Assignee: Paul Rogers
> Priority: Minor
>
> Command to find JAVA in drill-config.sh is not deterministic.
> drill-config.sh uses the following command to find JAVA:
> JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1`
> On one of my node the following command returned 2 entries:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> /usr/local/java/jdk1.7.0_67/bin/java
> On another node, the same command returned entries in different order:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/bin/java
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> The complete command picks the first one returned which may not be the same
> on each node:
> find -L $JAVA_HOME -name java -type f | head -n 1
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> If JAVA_HOME is found, we should just append the "bin/java" to the path"
> JAVA=$JAVA_HOME/bin/java
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
