[
https://issues.apache.org/jira/browse/DRILL-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888257#comment-15888257
]
ASF GitHub Bot commented on DRILL-5301:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/764#discussion_r103481448
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -1722,8 +1774,68 @@ void DrillClientImpl::shutdownSocket(){
DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Socket shutdown" << std::endl;)
}
+namespace { // anonymous
--- End diff --
no, it's an anonymous namespace: the actual name is generated at
compilation time, and it prevents symbols to leak from outside object file, or
clash with other symbols (if not declared static).
> Add server metadata API
> -----------------------
>
> Key: DRILL-5301
> URL: https://issues.apache.org/jira/browse/DRILL-5301
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server, Client - C++, Client - Java, Client - JDBC,
> Client - ODBC
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
>
> JDBC and ODBC clients exposes lots of metadata regarding server version and
> support of various parts of the SQL standard.
> Currently the returned information is hardcoded in both clients/drivers which
> means that the infomation returned is support as of the client version, not
> the server version.
> Instead, a new method should be provided to the clients to query the actual
> server support. Support on the client or the server should be optional (for
> example a client should not use this API if the server doesn't support it and
> fallback to default values).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
