[
https://issues.apache.org/jira/browse/DRILL-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893705#comment-15893705
]
ASF GitHub Bot commented on DRILL-5313:
---------------------------------------
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/769
DRILL-5313: Fix compilation issue in C++ connector
DRILL-5301 and DRILL-5167 have conflicting changes, which causes
the C++ connector to not compile: the static symbol for the search
escape string has been removed as the server might use a different one.
Fix the issue by using the current search escape string (injected from the
meta to the internal drill client when querying metadata).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill laurent/DRILL-5313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/769.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #769
----
commit 795bdf53070ba2d20d65f23f0313b2777e334611
Author: Laurent Goujon <[email protected]>
Date: 2017-03-03T04:03:42Z
DRILL-5313: Fix compilation issue in C++ connector
DRILL-5301 and DRILL-5167 have conflicting changes, which causes
the C++ connector to not compile: the static symbol for the search
escape string has been removed as the server might use a different one.
Fix the issue by using the current search escape string (injected from the
meta to the internal drill client when querying metadata).
----
> C++ client build failure on linux
> ---------------------------------
>
> Key: DRILL-5313
> URL: https://issues.apache.org/jira/browse/DRILL-5313
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - C++
> Affects Versions: 1.10
> Reporter: Sorabh Hamirwasia
> Assignee: Laurent Goujon
>
> We are seeing below errors while building Drill C++ client on linux platform:
> [root@qa-node161 build]# make
> [ 6%] Built target y2038
> [ 38%] Built target protomsgs
> [ 41%] Building CXX object
> src/clientlib/CMakeFiles/drillClient.dir/drillClientImpl.cpp.o
> /root/drill/drill/contrib/native/client/src/clientlib/drillClientImpl.cpp: In
> function ‘void Drill::updateLikeFilter(exec::user::LikeFilter&, const
> std::string&)’:
> /root/drill/drill/contrib/native/client/src/clientlib/drillClientImpl.cpp:782:
> error: ‘s_searchEscapeString’ is not a member of ‘Drill::meta::DrillMetadata’
> make[2]: *** [src/clientlib/CMakeFiles/drillClient.dir/drillClientImpl.cpp.o]
> Error 1
> make[1]: *** [src/clientlib/CMakeFiles/drillClient.dir/all] Error 2
> make: *** [all] Error 2
> It looks to be related to one of Laurent's pull request below:
> https://github.com/apache/drill/pull/712
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
