[
https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925490#comment-15925490
]
ASF GitHub Bot commented on DRILL-3510:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r106083106
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException
{
return serverMeta;
}
+ /**
+ * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but
updates server metadata for the every call
+ * @return server meta information
+ * @throws SQLException for error when getting server meta
+ */
+ private ServerMeta getUpdatedServerMeta() throws SQLException {
--- End diff --
There's nothing in the JDBC spec which says if this has to be refreshed
when user session is changed manually. It seems that MySQL doesn't do a server
call each time, but I haven't checked other drivers (not all databases allow to
change the quoting identifier in the session).
I would say it might not be necessary as someone who changed manually the
quoting know that he/she is dealing with Drill and that he/she changed the the
default quoting identifier. But people might have strong arguments in favor of
refreshing...
> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL
> identifiers
> --------------------------------------------------------------------------------------
>
> Key: DRILL-3510
> URL: https://issues.apache.org/jira/browse/DRILL-3510
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Reporter: Jinfeng Ni
> Assignee: Vitalii Diravka
> Labels: doc-impacting
> Fix For: 1.10.0
>
> Attachments: DRILL-3510.patch, DRILL-3510.patch
>
>
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as
> what MySQL does. However, this is different from ANSI SQL specification,
> where double quote is used as identifier quotes.
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user.
> Drill should follow the same way, so that Drill users do not have to rewrite
> their existing queries, if their queries use double quotes.
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
