[
https://issues.apache.org/jira/browse/DRILL-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933186#comment-15933186
]
ASF GitHub Bot commented on DRILL-5368:
---------------------------------------
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/790
DRILL-5368: Fix memory leak issue in
DrillClientImpl::processServerMetaResult
Fix a small memory leak by doing local allocation instead since the
object doesn't escape the function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill laurent/DRILL-5368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/790.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #790
----
commit a2e209e772d9613bdc081d7044f66aaeb7338d28
Author: Laurent Goujon <[email protected]>
Date: 2017-03-20T17:55:17Z
DRILL-5368: Fix memory leak issue in
DrillClientImpl::processServerMetaResult
Fix a small memory leak by doing local allocation instead since the
object doesn't escape the function.
----
> Memory leak in C++ server metadata handler
> ------------------------------------------
>
> Key: DRILL-5368
> URL: https://issues.apache.org/jira/browse/DRILL-5368
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - C++
> Affects Versions: 1.10.0
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Minor
>
> When receiving server metadata response, a protobuf ServerMetaResp object is
> dynamically allocated but never freed.
> Since for this handler, there's no need to keep the instance attached to the
> handler (content is copied over by the MetaData class), a reference is enough
> and allocation can be done on the stack.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
