[
https://issues.apache.org/jira/browse/DRILL-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942166#comment-15942166
]
ASF GitHub Bot commented on DRILL-5089:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/795#discussion_r108050543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
---
@@ -185,6 +186,35 @@ public static AbstractSchema
resolveToMutableDrillSchema(final SchemaPlus defaul
}
/**
+ * Given a schema in schema tree, once this schema is found resolve it
into a mutable <i>AbstractDrillSchema</i>
+ * instance. A {@link UserException} is throws when:
+ * 1. Schema is a root schema
+ * 2. schema is not a mutable schema.
+ * @param schema
+ * @return
+ */
+ public static AbstractSchema toMutableDrillSchema(final SchemaPlus
schema) {
+ if (schema == null) {
+ throwSchemaNotFoundException(schema, schema.getName());
--- End diff --
Err... If schema is null, then `schema.getName()` will throw an NPE...
Why would the schema be null? Should this be:
```
assert schema != null;
```
> Skip initializing all enabled storage plugins for every query
> -------------------------------------------------------------
>
> Key: DRILL-5089
> URL: https://issues.apache.org/jira/browse/DRILL-5089
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.9.0
> Reporter: Abhishek Girish
> Assignee: Chunhui Shi
> Priority: Critical
>
> In a query's lifecycle, at attempt is made to initialize each enabled storage
> plugin, while building the schema tree. This is done regardless of the actual
> plugins involved within a query.
> Sometimes, when one or more of the enabled storage plugins have issues -
> either due to misconfiguration or the underlying datasource being slow or
> being down, the overall query time taken increases drastically. Most likely
> due the attempt being made to register schemas from a faulty plugin.
> For example, when a jdbc plugin is configured with SQL Server, and at one
> point the underlying SQL Server db goes down, any Drill query starting to
> execute at that point and beyond begin to slow down drastically.
> We must skip registering unrelated schemas (& workspaces) for a query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
