[
https://issues.apache.org/jira/browse/DRILL-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959540#comment-15959540
]
ASF GitHub Bot commented on DRILL-5415:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/807#discussion_r110238313
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -203,7 +219,15 @@ private void createConfig(FixtureBuilder builder)
throws Exception {
if (builder.configResource != null) {
config = DrillConfig.create(builder.configResource);
} else if (builder.configProps != null) {
- config = DrillConfig.create(configProperties(builder.configProps));
+ // Create Config object out of all the String type configuration.
--- End diff --
Suggestion to keep things tidy. Keep all properties (simple and complex) in
the builder's `configProps` object. Then, in `configProperties`, do the mapping
as required to create the `DrillConfig`. If a value is a collection, use the
new code to set the value. Else, convert the value using `toString()`.
> Improve Fixture Builder to configure client properties and keep collection
> type properties for server
> -----------------------------------------------------------------------------------------------------
>
> Key: DRILL-5415
> URL: https://issues.apache.org/jira/browse/DRILL-5415
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.11.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Minor
> Fix For: 1.11.0
>
>
> There are 2 improvements which are made as part of this pull request.
> 1) The Fixture Builder framework converts all the config properties for
> Drillbit into string type. But there are certain configurations for
> authentication (like auth.mechanism) which are expected to be list type. Thus
> there will be failure during type check. Change to keep collections type
> config value as is and insert those config value after string types are
> inserted.
> 2) The Fixture Builder framework when builds it tries to apply any system
> options / session options (if set) for which it creates a default client.
> Hence with cluster enabled for authentication this default client will not
> provide any connection parameters for authentication and will fail to
> connect. Allow Fixture Builder to accept client related properties as well so
> that can be used while creating default client to connect to cluster.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
