[ 
https://issues.apache.org/jira/browse/DRILL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5405:
------------------------------------
    Description: 
Source - https://github.com/apache/drill/pull/214#discussion_r42687575

Some operator types are not added in CoreOperatorType enum.
For example, FLATTEN, MONGO_SUB_SCAN, MAPRDB_SUB_SCAN so they won't be 
displayed on Web UI as UNKNOWN_OPERATOR.
Screenshots:
now -> unknown_operator.JPG
should be -> maprdb_sub_scan.JPG

Though plugins work fine without this changes, it's still would be nice to 
display operator type on Web UI.
But dependency on protobuf enum removes the ability for format plugins to truly 
be drop-in pluggable.
In this case as option we may need to refactor this interface to just return a 
String and not use the protobuf enum, or have a separate "notes" field if we 
want to have a generic filescan operator ID in this enum with extra data to say 
what kind of scan we used.

  was:
Add missing operator types: FLATTEN, MONGO_SUB_SCAN, MAPRDB_SUB_SCAN so they 
won't be displayed on Web UI as UNKNOWN_OPERATOR.

Example:
before the fix -> unknown_operator.JPG
after the fix -> maprdb_sub_scan.JPG


> Add missing operator types
> --------------------------
>
>                 Key: DRILL-5405
>                 URL: https://issues.apache.org/jira/browse/DRILL-5405
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>             Fix For: 1.11.0
>
>         Attachments: maprdb_sub_scan.JPG, unknown_operator.JPG
>
>
> Source - https://github.com/apache/drill/pull/214#discussion_r42687575
> Some operator types are not added in CoreOperatorType enum.
> For example, FLATTEN, MONGO_SUB_SCAN, MAPRDB_SUB_SCAN so they won't be 
> displayed on Web UI as UNKNOWN_OPERATOR.
> Screenshots:
> now -> unknown_operator.JPG
> should be -> maprdb_sub_scan.JPG
> Though plugins work fine without this changes, it's still would be nice to 
> display operator type on Web UI.
> But dependency on protobuf enum removes the ability for format plugins to 
> truly be drop-in pluggable.
> In this case as option we may need to refactor this interface to just return 
> a String and not use the protobuf enum, or have a separate "notes" field if 
> we want to have a generic filescan operator ID in this enum with extra data 
> to say what kind of scan we used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to