[
https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993046#comment-15993046
]
ASF GitHub Bot commented on DRILL-4335:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r114334527
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcEncoder.java
---
@@ -111,7 +111,7 @@ protected void encode(ChannelHandlerContext ctx,
OutboundRpcMessage msg, List<Ob
cos.writeRawVarint32(rawBodyLength);
cos.flush(); // need to flush so that dbody goes after if cos is
caching.
- CompositeByteBuf cbb = new CompositeByteBuf(buf.alloc(), true,
msg.dBodies.length + 1);
+ final CompositeByteBuf cbb =
ctx.alloc().compositeBuffer(msg.dBodies.length + 1);
--- End diff --
`ctx.alloc().compositeDirectBuffer(...)`
> Apache Drill should support network encryption
> ----------------------------------------------
>
> Key: DRILL-4335
> URL: https://issues.apache.org/jira/browse/DRILL-4335
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Keys Botzum
> Assignee: Sorabh Hamirwasia
> Labels: security
> Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this
> needs to include network level encryption and not just authentication. This
> is particularly important for the client connection to Drill which will often
> be sending passwords in the clear until there is encryption.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
