[
https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009629#comment-16009629
]
ASF GitHub Bot commented on DRILL-5481:
---------------------------------------
GitHub user kkhatua reopened a pull request:
https://github.com/apache/drill/pull/834
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
1. Introduced an InMemoryStoreProvider with the ability to maintain a max
capacity
2. DrillbitContext now explicitly has a profileStoreProvider that, by
default, re-uses the general PersistentStoreProvider, unless it is InMemory,
which is when #1 is used.
2. Cleanly separated out QueryProfileStoreContext
3. Converted literal values to constants within ExecConstants
4. Updated drill-module.conf for default capacity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-5481-alt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #834
----
commit 879ab586b3c38c7088cfdec3458ae6b69a8115c2
Author: Kunal Khatua <[email protected]>
Date: 2017-05-14T07:27:43Z
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
1. Introduced an InMemoryStoreProvider with the ability to maintain a max
capacity
2. DrillbitContext now explicitly has a profileStoreProvider that, by
default, re-uses the general PersistentStoreProvider, unless it is InMemory,
which is when #1 is used.
2. Cleanly separated out QueryProfileStoreContext
3. Converted literal values to constants within ExecConstants
4. Updated drill-module.conf for default capacity
----
> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
> Key: DRILL-5481
> URL: https://issues.apache.org/jira/browse/DRILL-5481
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the
> life of the Drillbit), an existing test class
> {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored
> to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and
> given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit
> process' lifespan.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
