[
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014763#comment-16014763
]
ASF GitHub Bot commented on DRILL-5457:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r117106477
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java ---
@@ -188,6 +188,18 @@
NOT_YET,
/**
+ * Restart reading incoming batches.
+ * <p>
+ * Prior calls to {@link #next()} returned data after all incoming
batches were processed.
+ * But with this status, need to restart reading incoming
RecordBatches.
+ * </p>
+ * <p>
+ * Currently only used internally by the Hash Aggregate.
+ * </p>
+ */
--- End diff --
Not entirely sure we want to extend the core Volcano iterator protocol to
help with a single operator. In general, ALL operators should be prepared to
handle this value since it is part of the public protocol.
Can we find a way to avoid this? I suspect some code restructuring, along
with an operator-specific enum, would do the trick.
> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
> Key: DRILL-5457
> URL: https://issues.apache.org/jira/browse/DRILL-5457
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.10.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too
> small to allow in memory work for the Hash Aggregate Operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
