[
https://issues.apache.org/jira/browse/DRILL-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016607#comment-16016607
]
ASF GitHub Bot commented on DRILL-5504:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/832#discussion_r117358723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -449,4 +449,19 @@
String PERSISTENT_TABLE_UMASK = "exec.persistent_table.umask";
StringValidator PERSISTENT_TABLE_UMASK_VALIDATOR = new
StringValidator(PERSISTENT_TABLE_UMASK, "002");
+ /**
+ * When iterator validation is enabled, additionally validates the
vectors in
+ * each batch passed to each iterator.
+ */
+ String ENABLE_VECTOR_VALIDATION = "debug.validate_vectors";
+ BooleanValidator ENABLE_VECTOR_VALIDATOR = new
BooleanValidator(ENABLE_VECTOR_VALIDATION, true);
--- End diff --
Good catch. Fixed.
But, that error actually accidentally caught a bug...
> Vector validator to diagnose offset vector issues
> -------------------------------------------------
>
> Key: DRILL-5504
> URL: https://issues.apache.org/jira/browse/DRILL-5504
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.11.0
>
>
> DRILL-5470 describes a case in which an offset vector appears to have become
> corrupted, yielding a bogus field-length value that is orders of magnitude
> larger than the vector that contains the data.
> Debugging such cases is slow and tedious. To help, we propose to create a
> "vector validator" that spins through vectors looking for problems.
> Then, to allow the validator to be used in the field, extend the "iterator
> validator batch iterator" to optionally allow vector validation on each batch.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)