[
https://issues.apache.org/jira/browse/DRILL-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048718#comment-16048718
]
ASF GitHub Bot commented on DRILL-5587:
---------------------------------------
GitHub user ppadma opened a pull request:
https://github.com/apache/drill/pull/852
DRILL-5587: Validate Parquet blockSize and pageSize configured with S…
…YSTEM/SESSION option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppadma/drill DRILL-5587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #852
----
commit 8e0be0b283583be5ccfe32dc6b0f805424880fb4
Author: Padma Penumarthy <[email protected]>
Date: 2017-06-14T00:23:17Z
DRILL-5587: Validate Parquet blockSize and pageSize configured with
SYSTEM/SESSION option
----
> Validate Parquet blockSize and pageSize configured with SYSTEM/SESSION option
> -----------------------------------------------------------------------------
>
> Key: DRILL-5587
> URL: https://issues.apache.org/jira/browse/DRILL-5587
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Parquet
> Affects Versions: 1.10.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Fix For: 1.11.0
>
>
> We can set Parquet blockSize, pageSize and dictionary pageSize to any value.
> It uses LongValidator which is not exactly validating the value. Since all
> these sizes are used as int in the code, even though user is able to set them
> to any value (could be greater than MAXINT and/or negative), parsing the
> value later in the code as int can throw an error. Instead, restrict the
> value that can be set to MAXINT.
> There is a bug open for validating system/session options in general.
> https://issues.apache.org/jira/browse/DRILL-2478
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
