[ 
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051077#comment-16051077
 ] 

ASF GitHub Bot commented on DRILL-5457:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r122310373
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ---
    @@ -154,7 +152,7 @@
       private int cycleNum = 0; // primary, secondary, tertiary, etc.
       private int originalPartition = -1; // the partition a secondary reads 
from
     
    -  private class SpilledPartition { public int spilledBatches; public 
String spillFile /* Path filePath */; int cycleNum; int origPartn; int 
prevOrigPartn; }
    +  private class SpilledPartition { public int spilledBatches; public 
String spillFile; int cycleNum; int origPartn; int prevOrigPartn; }
    --- End diff --
    
    `private static class` since you don't have any methods and so have no use 
for the "inner this" pointer.


> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
>                 Key: DRILL-5457
>                 URL: https://issues.apache.org/jira/browse/DRILL-5457
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.10.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too 
> small to allow in memory work for the Hash Aggregate Operator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to