[
https://issues.apache.org/jira/browse/DRILL-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051378#comment-16051378
]
ASF GitHub Bot commented on DRILL-5589:
---------------------------------------
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/854
Thanks! . I added your name in JIRA as reviewer.
Thanks,
Sorabh
________________________________
From: Karthikeyan Manivannan <[email protected]>
Sent: Thursday, June 15, 2017 7:44:31 PM
To: apache/drill
Cc: Sorabh Hamirwasia; Author
Subject: Re: [apache/drill] DRILL-5589: JDBC client crashes after
successful authentication if tr… (#854)
@bitblender commented on this pull request.
LGTM +1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/drill/pull/854#pullrequestreview-44463788>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AVIgYzw_xX0d3GYuqstvV6viNVYmyjJGks5sEewPgaJpZM4N7r7L>.
> JDBC client crashes after successful authentication if trace logging is
> enabled.
> --------------------------------------------------------------------------------
>
> Key: DRILL-5589
> URL: https://issues.apache.org/jira/browse/DRILL-5589
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.11.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Labels: ready-to-commit
>
> When authentication is completed then with latest changes we [dispose the
> saslClient instance |
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java#L295]
> if encryption is not enabled. Then later in caller we try to [log the
> mechanism name |
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java#L136]
> using saslClient instance with trace level logging. This will cause the
> client to crash since the saslClient instance is already disposed before
> logging.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
